Cleanup PyMemberDef
#3031
Merged
Cleanup PyMemberDef
#3031
+3
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mgeplf
commented
Aug 6, 2024
mgeplf
commented
- remove some unused variables at the same time
* bonus, shouldn't leak memory any more
|
✔️ 6017cd2 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
- Coverage 67.28% 67.27% -0.02%
==========================================
Files 571 571
Lines 104913 104905 -8
==========================================
- Hits 70588 70570 -18
- Misses 34325 34335 +10 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
reviewed
Aug 7, 2024
1uc
approved these changes
Aug 7, 2024
|
✔️ e14c84f -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 7403e85 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
✔️ 682e36b -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.